Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(e2e): set exact commit sha to use for e2e images #1149

Merged
merged 5 commits into from
Feb 26, 2024
Merged

ci(e2e): set exact commit sha to use for e2e images #1149

merged 5 commits into from
Feb 26, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Feb 26, 2024 •
edited
Loading

Resolves #1146

Summary

  • Modify ./deploy.py and E2E github workflow to use exact commit sha to pull the right docker images.
  • Wait for exact sha rather than branch in the "wait for docker image build completion" action in E2E workflow
  • Also add --verbose flag to ./deploy.py and use it in E2E, so it's easier to debug those actions when changing them.
  • Also fix bug introduced in Try out caching in docke build actions #958 when I specified the wrong E2E workflow

@corneliusroemer corneliusroemer merged commit fdc00dd into main Feb 26, 2024
9 checks passed
@corneliusroemer corneliusroemer deleted the deploy-helm-commit branch February 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theosanderson theosanderson theosanderson approved these changes

@fengelniederhammer fengelniederhammer Awaiting requested review from fengelniederhammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run E2E with specific commit hash, rather than branch tags
2 participants
@corneliusroemer @theosanderson